On Tue, Dec 19, 2017 at 8:15 PM, Joe Perches joe@perches.com wrote:
Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
Done with perl script:
$ git grep -w --name-only DEVICE_ATTR | \ xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*(\s*(\w+)\s*,\s*(?(\s*S_IRUGO\s*|\s*S_IWUSR|\s*S_IWUSR\s*|\s*S_IRUGO\s*|\s*0644\s*))?\s*,\s*\1_show\s*,\s*\1_store\s*)/DEVICE_ATTR_RW(\1)/g; print;}'
drivers/platform/x86/compal-laptop.c | 18 +++++----------
--- a/drivers/platform/x86/compal-laptop.c +++ b/drivers/platform/x86/compal-laptop.c @@ -679,18 +679,12 @@ static int bat_writeable_property(struct power_supply *psy, /* ============== */ /* Driver Globals */ /* ============== */ -static DEVICE_ATTR(wake_up_pme,
0644, wake_up_pme_show, wake_up_pme_store);-static DEVICE_ATTR(wake_up_modem,
0644, wake_up_modem_show, wake_up_modem_store);-static DEVICE_ATTR(wake_up_lan,
0644, wake_up_lan_show, wake_up_lan_store);-static DEVICE_ATTR(wake_up_wlan,
0644, wake_up_wlan_show, wake_up_wlan_store);-static DEVICE_ATTR(wake_up_key,
0644, wake_up_key_show, wake_up_key_store);-static DEVICE_ATTR(wake_up_mouse,
0644, wake_up_mouse_show, wake_up_mouse_store);+static DEVICE_ATTR_RW(wake_up_pme); +static DEVICE_ATTR_RW(wake_up_modem); +static DEVICE_ATTR_RW(wake_up_lan); +static DEVICE_ATTR_RW(wake_up_wlan); +static DEVICE_ATTR_RW(wake_up_key); +static DEVICE_ATTR_RW(wake_up_mouse);
Acked-by: Andy Shevchenko andy.shevchenko@gmail.com
for PDx86 bits.
Have to say that while it doesn't change the attributes here, it might require still to be revisited by security people, if they wish.