smatch reports sound/soc/codecs/max98388.c:890:39: warning: symbol 'soc_codec_dev_max98388' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static.
Signed-off-by: Tom Rix trix@redhat.com --- sound/soc/codecs/max98388.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/max98388.c b/sound/soc/codecs/max98388.c index 8062a7115007..b7d1d5c7b72f 100644 --- a/sound/soc/codecs/max98388.c +++ b/sound/soc/codecs/max98388.c @@ -887,7 +887,7 @@ static const struct regmap_config max98388_regmap = { .cache_type = REGCACHE_RBTREE, };
-const struct snd_soc_component_driver soc_codec_dev_max98388 = { +static const struct snd_soc_component_driver soc_codec_dev_max98388 = { .probe = max98388_probe, .controls = max98388_snd_controls, .num_controls = ARRAY_SIZE(max98388_snd_controls),