28 Jul
2016
28 Jul
'16
10:51 p.m.
On Thu, Jul 28, 2016 at 10:40:44PM +0200, Lars-Peter Clausen wrote:
- /* Check if MCLK provided */
- rt5659->mclk = devm_clk_get(&i2c->dev, "mclk");
- if (IS_ERR(rt5659->mclk)) {
if (PTR_ERR(rt5659->mclk) == -EPROBE_DEFER)return -EPROBE_DEFER;The correct thing to do here is to check if != -ENOENT and then return the error code. Otherwise you silently ignore errors if a clock was specified, but there was an error requesting it.
Oh..Thanks for the input. Will refine it in v2.