At Mon, 09 Apr 2012 09:12:44 -0600, Stephen Warren wrote:
On 04/08/2012 08:15 PM, Fengguang Wu wrote:
These trivial messages will show up repeatedly on hot plug as well as video mode changes, which could be annoying.
Signed-off-by: Wu Fengguang fengguang.wu@intel.com
Those messages are very useful for end-users to diagnose problems with HDMI audio. Is there a way to make the messages dynamic, so users can get them if they want, without recompiling their kernel?
We can define a new macro like below, add call like _snd_printd(2, ....) instead of snd_printd(). (Yes, the number 2 can be replaced better in an enum, too.)
In future, we should move to the standard dynamic_printk, but a patch like this would be a good compromise for merging to 3.4 kernel, IMO.
Takashi
--- diff --git a/include/sound/core.h b/include/sound/core.h index b6e0f57..442f822 100644 --- a/include/sound/core.h +++ b/include/sound/core.h @@ -354,6 +354,8 @@ void __snd_printk(unsigned int level, const char *file, int line, */ #define snd_printd(fmt, args...) \ __snd_printk(1, __FILE__, __LINE__, fmt, ##args) +#define _snd_printd(level, fmt, args...) \ + __snd_printk(level, __FILE__, __LINE__, fmt, ##args)
/** * snd_BUG - give a BUG warning message and stack trace @@ -383,6 +385,7 @@ void __snd_printk(unsigned int level, const char *file, int line, #else /* !CONFIG_SND_DEBUG */
#define snd_printd(fmt, args...) do { } while (0) +#define _snd_printd(level, fmt, args...) do { } while (0) #define snd_BUG() do { } while (0) static inline int __snd_bug_on(int cond) {