On Fri, 2017-08-25 at 15:21 +0100, Mark Brown wrote:
On Fri, Aug 25, 2017 at 04:33:08PM +0300, Andy Shevchenko wrote:
On Fri, 2017-08-25 at 14:11 +0100, Mark Brown wrote:
On Thu, Aug 24, 2017 at 06:11:12PM +0200, Takashi Iwai wrote:
Well, that's what the commit ddc9e69b9dc2 does after all: it cleans up the legacy usage, and moves all either OF or ACPI matching.
Which is broken since not all the world is ACPI or DT.
While I agree on the second part, I don't think it's broken per se, there never was a single user of that, and looking how ASoC board files are organized it is quite unlikely there will be one...
I have no idea why you say the ASoC machine drivers would prevent someone adding a platform based user,
For example, looking into sound/soc/mediatek/mt8173/mt8173-rt5650-rt5676.c I see a direct use of codec driver without any platform driver involvement.
Is it exception from the rule, or a common use?
obviously ASoC predates the use of both ACPI and DT quite considerably.
Yep, the current users of driver in question either DT or ACPI, would it be pure platform in the future?
That's what I said, yes.
...though we can (re)introduce this dead code back for a potential user in the future.
The IDs are back as a result of the merge resolution I did.
I'm fine as long as it doesn't include broken 'ACPI instance as I2C ID'. Thanks!