Re: [alsa-devel] [PATCH 15/20] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX

Shawn Guo wrote:

+#ifdef PPC +#define read_ssi(addr) in_be32(addr) +#define write_ssi(val, addr) out_be32(addr, val) +#elif defined ARM +#define read_ssi(addr) readl(addr) +#define write_ssi(val, addr) writel(val, addr) +#endif

Can you also add an ARM version of clrsetbits_be32()? Something like this:

#ifdef PPC #define read_ssi(addr) in_be32(addr) #define write_ssi(val, addr) out_be32(addr, val) #define write_ssi_mask(addr, clear, set) clrsetbits_be32(addr, clear, set) #elif defined ARM #define read_ssi(addr) readl(addr) #define write_ssi(val, addr) writel(val, addr) #define write_ssi_mask(addr, clear, set) \ { u32 __val; \ val = readl(&ssi->scr); \ val = (val & ~(clear) | (set); \ writel(val, addr) #endif