On Wed, Dec 9, 2009 at 8:09 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Wed, Dec 09, 2009 at 01:29:54PM +0900, jassisinghbrar@gmail.com wrote:
- if (!request_mem_region(res->start, resource_size(res),
- "s3c64xx-i2s")) {
- dev_err(&pdev->dev, "Unable to request SFR region\n");
- return -EBUSY;
- }
This feels like it should be in the patch that requested the resource rather than here. Probably ought to have a version that does the request in 2.6.33 too if we can...
that patch is only for setting DMA channel and dst addresses, so we request MEM resource there.
@@ -191,7 +198,8 @@ static __devinit int s3c64xx_iis_dev_probe(struct platform_device *pdev)
clk_enable(i2s->iis_cclk);
- ret = s3c_i2sv2_probe(pdev, dai, i2s, 0);
- ret = s3c_i2sv2_probe(pdev, dai, i2s,
- i2s->dma_playback->dma_addr - S3C2412_IISTXD);
if (ret) goto err_clk;
A comment explaining why we're doing the subtraction wouldn't hurt; the code is OK.
its just that i didn't want to reorder the code and MEM resource was requested into a temporary variable 'res' not immediately before this call. At this point res->start should do too though.