At Thu, 9 Jan 2014 12:27:00 +0000, Corfu, ValentinX wrote:
The current jack client name contains the process id of the application providing the audio samples. This leads to unpredictable jack client names which makes handling of the connections by a controlling application very hard. The modification now allows to specify a client name and the number of channels as parameters in the configuration file The given number of channels are then created but not connected. The implementation is backward compatible and simply adds a new configuration option to the plugin.
Could you try to embed your patch in the mail for review?
In anyway, please fix the following and resubmit:
- The indentation should be aligned with other codes
- DontIntroduceUglyNameRule.
- The standard naming mode could be identified via an empty string, so you can remove one flag
- A way too many changes in a single patch; split to multiple patches to implement each feature, passing the port name string, the channels, etc.
thanks,
Takashi
Intel Shannon Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
[2 0001-PATCH-alsa-plugins-Modify-jack-client-name.patch <application/octet-stream (base64)>]
[3 <text/plain; us-ascii (7bit)>] _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel