Hi Takashi Iwai!
On Mon, Dec 17, 2007 at 03:38:26PM +0100, Takashi Iwai wrote next:
Some to be discussed. I found the SND_PCI_QUIRK group (lines with this macro under one structure) is unsorted. Almost in all cases no sense to make so. I wrote python script to keep lists sorted. Please, comment this.
Thanks, that's nice. I applied it and fixed some entries manually (e.g. the wildcard one with device_id = 0). Now patch_*.c have sorted list except for patch_sigmatel.c.
Yes, I find all sources with that macro and try to fix it.
First of, sigmatel need to be more complex algorithm.
Second, I wrote new (optimized) version of script (see attachment).
Third, the script makes warnings with the duplicate lines with the same vendor and product id pair. Good to search possible collision.
Fourth, in appearance we need to separate some blocks in the structure by empty lines like following
struct { ... SND_PCI_QUIRK section1 ... <empty line> section2 ... {} }
And then sort only in the sections of the groups. I'll think about that. This case is a good to apply even to patch_sigmatel.c
As result, we need some special rules for these structures to keep they in prefer manner.