On Mon, Sep 22, 2014 at 10:21:19AM +0200, Takashi Iwai wrote:
At Mon, 22 Sep 2014 13:45:41 +0530, Sudip Mukherjee wrote:
On Mon, Sep 22, 2014 at 09:04:53AM +0200, Takashi Iwai wrote:
At Sun, 21 Sep 2014 21:33:37 +0530, Sudip Mukherjee wrote:
added and initialized a pointer of snd_card in the struct hw to get a reference of the card in other functions
You need to explain why this change is needed. The above text shows what it'd do, but it doesn't give any explanation to convince why this patch must be merged in. In this case, it's a preliminary patch for the changes to convert to dev_*() later. It's the most important bit, so don't forget it.
then do i mention in the commit that it is the preliminary patch for the later changes to dev_* ?
If the purpose of this patch is so, just write what it'll be used for.
i was thinking that we can get a reference of the card from other functions which are using struct hw is a reason by itself.
If the purpose of this patch is rather broader, just write what it'll be used for.
Do you see what was missing?
understood. thanks . I hope v4 will be a better series than this .
sudip
Takashi