Re: [alsa-devel] [PATCH] topology: ABI: Increase SND_SOC_TPLG_NUM_TEXTS to 32

On Fri, Jul 20, 2018 at 03:57:07PM +0530, Puneeth Prabhu wrote:

index bb8aec7..eb61483 100644 --- a/include/sound/asoc.h +++ b/include/sound/asoc.h @@ -84,7 +84,7 @@ #define SND_SOC_TPLG_MAGIC 0x41536F43 /* ASoC */

/* string sizes */ -#define SND_SOC_TPLG_NUM_TEXTS 16 +#define SND_SOC_TPLG_NUM_TEXTS 32

/* ABI version */ #define SND_SOC_TPLG_ABI_VERSION 0x5 /* current version */

Hrm, we should be getting rid of the duplication here - include the UAPI header in sound/asoc.h rather than duplicating definitions between the two. Otherwise someone might modify something in sound/asoc.h and not realize that the UAPI is affected.