On Thu, Feb 27, 2014 at 11:17:27AM +0400, Alexander Shiyan wrote:
Четверг, 27 февраля 2014, 12:44 +09:00 от Mark Brown broonie@kernel.org:
I'm wondering if the FIQ code can be shared with the i.MX FIQ code? Not something that should block merging but it seems like it might be helpful for other platforms that need to use FIQ support.
This FIQ implementation and i.MX FIQ is totally different. I am fully confident that we can not use any common features/calls.
The timer stuff looked a bit familiar...
+#if defined(CONFIG_SND_CLPS711X_SOC_MODULE) +irqreturn_t no_action(int irq, void *dev_id) +{
- return IRQ_NONE;
+} +#endif
Eh? Waht's this about?
In case using this driver as non-module, "no_action" handler is used from kernel/irq/handle.c, but since it is not exported it cannot be used in module case. I'll remade this to use own empty handler always.
Please don't do this, fix the problem properly (for example by exporting it if that's the sensible thing to do).