15 Nov
2013
15 Nov
'13
6:43 p.m.
On Fri, Nov 15, 2013 at 09:03:36AM -0800, Joe Perches wrote:
On Fri, 2013-11-15 at 17:28 +0100, Florian Meier wrote:
+static size_t bcm2835_dma_desc_size_pos(struct bcm2835_desc *d, dma_addr_t addr) +{
- unsigned i;
- size_t size;
Please set size to 0 here and not in the for loop
- for (size = i = 0; i < d->frames; i++) {
I disagree with that comment; I think the above is not only cleaner, but also more obvious that _this_ loop is calculating _this_ size.