-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Thursday, April 30, 2015 1:02 PM To: Fang, Yang A Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; dgreid@chromium.org; Koul, Vinod; Diwakar, Praveen; kevin.strasser@linux.intel.com; Jain, Praveen K; Iriawan, Denny Subject: Re: [PATCH 3/4] ASoC: ts3a227e: add platform data for ts3a227e driver
On Wed, Apr 29, 2015 at 06:43:57PM -0700, yang.a.fang@intel.com wrote:
@@ -296,7 +303,7 @@ static int ts3a227e_i2c_probe(struct i2c_client *i2c, }
ret = devm_request_threaded_irq(dev, i2c->irq, NULL,
ts3a227e_interrupt,
IRQF_TRIGGER_LOW |IRQF_ONESHOT,
ts3a227e->pdata.irqflag, "TS3A227E", ts3a227e);This doesn't make much sense to me - no change is made to the configuration of the device, the driver just passes the flag through to the interrupt controller code. I can't see how that's going to work well, somewhere along the line something must be misconfigured.
Hi Mark,
My intention is to make irqflag configurable. I made them two patches. Patch 3/4 to make sure existing code no impact. 4/4 is set different Irq value via DMI for specific platform. Maybe I should squash them?
Thanks, Yang