Mark Brown wrote at Thursday, February 03, 2011 3:53 PM:
On Thu, Feb 03, 2011 at 01:56:18PM -0700, Stephen Warren wrote:
At present, I'm not sure how best to resolve this. Downstream drivers directly tweaked the wm8903's registers so that both ADCs processed the same input channel.
The CODEC driver needs to have support for routing the left and right channels like things like the WM8993 do.
{"IN1L", NULL, "Mic Jack"},
- {"IN1R", NULL, "Mic Jack"},
This looks odd - I'd expect to see separate widgets for the internal microphone rather than using the same widget.
Yes, separate widgets would make sense.
However, I wonder how this interacts with mic detection using micbias current. There is only one mic bias signal, routed to a subset of the mics using the two per-mic enable GPIOs. Should I just hook up the mic bias detection to both jacks somehow, or is the only option to just punt on jack detection?
There are no physical plug detection mechanisms on this board.
This would greatly simplify the driver code without really impacting the level of configuration applications need to do (and allowing them to use both simultaneously if they want to).
I guess you could, although even with L/R routing implemented for the single-mic case, I think the only option for dual-mic would be to capture each mic on its own channel, which seems like an unlikely use case to me. But who knows, maybe it could be useful for e.g. noise-cancelling in SW?