Re: [alsa-devel] [PATCH] Add support for gain in softvol plugin

On Thu, 3 May 2007, Steve Longerbeam wrote:

Hi all,

What do you think of this patch? I tested this using a stac9205 HDA codec with all sample formats supported by softvol (s32, s16, s24, big and little endian).

I would not add extra defines to alsa.conf:

+defaults.pcm.dsnoop_softvol.card defaults.pcm.card +defaults.pcm.dsnoop_softvol.device defaults.pcm.device

Simply reuse pcm.dsnoop.card / device.

Otherwise - it looks good. Nice softvol extension.

Thanks, Jaroslav

----- Jaroslav Kysela perex@suse.cz Linux Kernel Sound Maintainer ALSA Project, SUSE Labs