On Fri, 25 Aug 2017 10:24:26 -0400, Tom Rini wrote:
On Fri, Aug 25, 2017 at 04:56:47PM +0300, Andy Shevchenko wrote:
+John
On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
Not all devices with ACPI and this combination of sound devices will have the required information provided via ACPI. Reintroduce the I2C device ID to restore sound functionality on on the Chromebook 'Samus' model.
Tom, one more question.
Apparently you are the one who tested the commit 89128534f925 ("ASoC: rt5677: Add ACPI support") year ago.
Yes.
The commit states that ACPI properties that are used in Chromebook Pixel 2015 is non-standard (not the same as for DT).
However, DSDT shows the opposite!
Interesting. I'm not an ACPI person, I just tested what John came up with.
And the patch adding this was the first (and still only) time I've really looked at ACPI, so it's quite possible that I misunderstood something at the time.
From memory, I think the particular problem I was referring to in the commit message was that certain GPIOs were only defined by index and not by property name (specifically "plug-det-gpios", "mic-present-gpios" and "headphone-enable-gpios"), and having dumped DSDT just now I do not see those strings appearing anywhere.