On Thu, May 28, 2015 at 03:37:24PM +0100, Mark Brown wrote:
On Thu, May 28, 2015 at 03:24:39PM +0100, Richard Fitzgerald wrote:
On Thu, May 28, 2015 at 02:57:51PM +0100, Mark Brown wrote:
adsp_dbg(dsp, "Shutdown complete\n");
adsp_info(dsp, "Shutdown complete (SCRATCH1:0x%x)\n", scratch1);That seems a bit loud for a diagnostic message, why raise the severity?
It's a diagnostic of the firmware, not the driver, and we can't assume that people trying to use a firmware have the ability to build and flash a kernel with a debug version of the driver
The default is that dev_dbg() is available in dmesg but not on the console which usually seems like a reasonable balance for this sort of thing - it's there if people want it but not included in the default logging.
What you're describing seems to be the default for dev_info(). For me I don't get any dev_dbg() output in the dmesg log unless the source file has a #define DEBUG at the top.