Re: [PATCH v2] ASoC: qcom: soundwire: Add support for controlling audio CGCR from HLOS

On 5/21/2022 8:43 AM, Stephen Boyd wrote: Thanks for your time Stephen!!!

Quoting Srinivasa Rao Mandadapu (2022-05-18 05:42:35)

...

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index da1ad7e..445e481 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1333,6 +1337,10 @@ static int qcom_swrm_probe(struct platform_device *pdev) ctrl->bus.compute_params = &qcom_swrm_compute_params; ctrl->bus.clk_stop_timeout = 300;

•   ctrl->audio_cgcr = devm_reset_control_get_exclusive(dev, "swr_audio_cgcr");
  

•   if (IS_ERR(ctrl->audio_cgcr))
  

•           dev_err(dev, "Failed to get audio_cgcr reset required for soundwire-v1.6.0\n");
  

Why is there no return on error here? Is the reset optional?

Yes it's optional. For older platforms this is not required.

...

•    ret = qcom_swrm_get_port_config(ctrl);
     if (ret)
             goto err_clk;