On Wed, 2007-11-21 at 10:53 +0100, Takashi Iwai wrote:
At Tue, 20 Nov 2007 15:31:26 +0100, Rene Herman wrote:
On 20-11-07 15:19, Thomas Renninger wrote:
At the end is some example code how things could get even more cleaned up. It shows how I think pnp layer and one example driver would get adjusted. There are not that much drivers making use of pnp_resource_change...
The ALSA ISA-PnP drivers do in what I personally consider a bad layering violation. Brought up not doing that a while ago on alsa-devel, but no discussion ensued. If the PnP maintainer(s) agree with me though, I'd be more than happy to rip all of that out of ALSA.
Rene: Could you do that, pls.
I'm fine with removal of that stuff now. It was implemented in that way because there was no proper way to re-assign ISA PnP resources on 2.4 kernel time. On 2.6, it makes no longer any sense (except for compatibility, but this is almost no problem for PnP boards).
I wasted some time on thinking about how this pnp_resource_change and pnp_manual_config_dev could get workarounded..., but it's impossible without changing the (more a workaround than an) interface.
If you worked on this already, would you mind ripping these out?
If I understand Takashi correctly, the driver code using pnp_resource_change and pnp_manual_config_dev can simply be removed and devices could get resources assigned via sysfs "set" interface.
Thanks,
Thomas