On 5/1/2018 5:08 AM, Srinivas Kandagatla wrote:
This patch adds support to memory map and unmap regions commands in q6asm module.
Signed-off-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org Reviewed-and-tested-by: Rohit kumar rohitkr@codeaurora.org
sound/soc/qcom/qdsp6/q6asm.c | 349 +++++++++++++++++++++++++++++++++++++++++++ sound/soc/qcom/qdsp6/q6asm.h | 5 + 2 files changed, 354 insertions(+)
diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index c9526d2e59d2..5a573e927a5e 100644 --- a/sound/soc/qcom/qdsp6/q6asm.c +++ b/sound/soc/qcom/qdsp6/q6asm.c @@ -18,10 +18,45 @@ #include "q6dsp-errno.h" #include "q6dsp-common.h"
<snip>
+/**
- q6asm_map_memory_regions() - map memory regions in the dsp.
- @dir: direction of audio stream
- @ac: audio client instanace
- @phys: physcial address that needs mapping.
- @period_sz: audio period size
- @periods: number of periods
- Return: Will be an negative value on failure or zero on success
- */
+int q6asm_map_memory_regions(unsigned int dir, struct audio_client *ac,
phys_addr_t phys,size_t period_sz, unsigned int periods)+{
- struct audio_buffer *buf;
- unsigned long flags;
- int cnt;
- int rc;
- spin_lock_irqsave(&ac->buf_lock, flags);
- if (ac->port[dir].buf) {
dev_err(ac->dev, "Buffer already allocated\n");spin_unlock_irqrestore(&ac->buf_lock, flags);return 0;- }
- buf = kzalloc(((sizeof(struct audio_buffer)) * periods), GFP_ATOMIC);
- if (!buf) {
spin_unlock_irqrestore(&ac->buf_lock, flags);return -ENOMEM;- }
Remove extra blank line.
Otherwise LGTM. Acked-by: Banajit Goswami bgoswami@codeaurora.org