Hi Broonie Thank for your feedback. I will resend them. One more thing, these day my colleague and I want have some adjustment on the tas2781 driver code to support both i2c and spi interface, and plan to abstract the common part, especially the dsp binary parsing, as a shared lib. Would you be so kind and give us some advice on it? Thanks.
-----Original Message----- From: Mark Brown broonie@kernel.org Sent: Tuesday, July 30, 2024 12:42 AM To: Ding, Shenghao shenghao-ding@ti.com Cc: andriy.shevchenko@linux.intel.com; lgirdwood@gmail.com; perex@perex.cz; pierre-louis.bossart@linux.intel.com; 13916275206@139.com; zhourui@huaqin.com; alsa-devel@alsa-project.org; Salazar, Ivan i-salazar@ti.com; linux-kernel@vger.kernel.org; Chadha, Jasjot Singh j-chadha@ti.com; liam.r.girdwood@intel.com; Yue, Jaden <jaden- yue@ti.com>; yung-chuan.liao@linux.intel.com; Rao, Dipa dipa@ti.com; yuhsuan@google.com; Lo, Henry henry.lo@ti.com; tiwai@suse.de; Xu, Baojun baojun.xu@ti.com; soyer@irl.hu; Baojun.Xu@fpt.com; judyhsiao@google.com; Navada Kanyana, Mukund navada@ti.com; cujomalainey@google.com; Kutty, Aanya aanya@ti.com; Mahmud, Nayeem nayeem.mahmud@ti.com; savyasanchi.shukla@netradyne.com; flaviopr@microsoft.com; Ji, Jesse jesse-ji@ti.com; darren.ye@mediatek.com; antheas.dk@gmail.com Subject: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move tas2563_dvc_table into a separate Header file
On Tue, Jul 16, 2024 at 02:11:21PM +0800, Shenghao Ding wrote:
Move tas2563_dvc_table into a separate Header file, as only tas2781 codec driver use this table, and hda side codec driver won't use it.
This doesn't apply against current code (or your other patch to this driver from the same day), please check and resend?