Re: [PATCH v1 1/1] soundwire: qcom: disable stop clock on 1.3.0 and below

Thank you!

On Sat, Apr 13, 2024 at 1:43 AM Anton Bambura jenneron@postmarketos.org wrote:

This patch returns back the behavior of disabling stop clock on soundwire 1.3.0 and below which seems to have been altered by accident which results in broken audio on sdm845 + wcd9340. For example, on AYN Odin and Lenovo Yoga C630 devices.

Fixes: 4830bfa2c812 ("soundwire: qcom: set clk stop need reset flag at runtime") Signed-off-by: Anton Bambura jenneron@postmarketos.org

---

drivers/soundwire/qcom.c | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index a1e2d6c98186..bc03484a28e8 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -628,6 +628,9 @@ static int qcom_swrm_enumerate(struct sdw_bus *bus) } }

•           if (ctrl->version <= SWRM_VERSION_1_3_0)
  

•                   ctrl->clock_stop_not_supported = true;
  

•           if (!found) {
                    qcom_swrm_set_slave_dev_num(bus, NULL, i);
                    sdw_slave_add(bus, &id, NULL);
  

-- 2.43.0

Tested on the Lenovo Yoga C630 Tested-by: Steev Klimaszewski steev@kali.org

-- steev