Re: [PATCH 07/12] ASoC: soc-component: add snd_soc_component_compr_get_codec_caps()

On Thu, 2020-11-12 at 13:37 +0900, Kuninori Morimoto wrote:

From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com

component related function should be implemented at soc-component.c. This patch adds snd_soc_component_compr_get_codec_caps().

Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com

include/sound/soc-component.h | 2 ++ sound/soc/soc-component.c | 21 +++++++++++++++++++++ sound/soc/soc-compress.c | 13 ++----------- 3 files changed, 25 insertions(+), 11 deletions(-)

diff --git a/include/sound/soc-component.h b/include/sound/soc- component.h index 7fd45462963e..d91e0eb1546d 100644 --- a/include/sound/soc-component.h +++ b/include/sound/soc-component.h @@ -455,6 +455,8 @@ int snd_soc_component_compr_get_params(struct snd_compr_stream *cstream, struct snd_codec *params); int snd_soc_component_compr_get_caps(struct snd_compr_stream *cstream, struct snd_compr_caps *caps); +int snd_soc_component_compr_get_codec_caps(struct snd_compr_stream *cstream,

• 			   struct snd_compr_codec_caps
  

*codec);

int snd_soc_pcm_component_pointer(struct snd_pcm_substream *substream); int snd_soc_pcm_component_ioctl(struct snd_pcm_substream *substream, diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c index 6f560238e2f9..2f1628100208 100644 --- a/sound/soc/soc-component.c +++ b/sound/soc/soc-component.c @@ -545,6 +545,27 @@ int snd_soc_component_compr_get_caps(struct snd_compr_stream *cstream, } EXPORT_SYMBOL_GPL(snd_soc_component_compr_get_caps);

+int snd_soc_component_compr_get_codec_caps(struct snd_compr_stream *cstream,

• 			   struct snd_compr_codec_caps
  

*codec) +{

• struct snd_soc_pcm_runtime *rtd = cstream->private_data;
• struct snd_soc_component *component;
• int i, ret;
• for_each_rtd_components(rtd, i, component) {

• if (component->driver->compress_ops &&
  

•     component->driver->compress_ops->get_codec_caps) {
  

• 	ret = component->driver->compress_ops-
  

...

get_codec_caps(

• 		component, cstream, codec);
  

• 	if (ret < 0)
  

• 		return soc_component_ret(component,
  

ret);

• }
  

• }
• return 0;

+} +EXPORT_SYMBOL_GPL(snd_soc_component_compr_get_codec_caps);

same comment for get_codec_caps() as well. We can maybe use this directly instead of soc_compr_get_codec_caps()?

Thanks,Ranjani