On Wed, Jan 05, 2011 at 06:29:24PM +0200, Jarkko Nikula wrote:
Mark Brown broonie@opensource.wolfsonmicro.com wrote:
Having thought about it for at least a second I think we should have a DAPM context in the cards for all the board-level stuff - does that seem resonable? The patch itself looks good:
I don't know. Probably it would be good if machine widgets are in own context. Like having own debugfs/sysfs directory for them etc.
Yes, exactly.
In this case it would be just enough if the tpa6130 is a codec driver having DAPM widgets. Then machine driver wouldn't need any these exported special tpa6130a2_ functions and soc-dapm could take care of power changes according to audio map and other info.
But as far as I understood there's no any better way to get rid of pops in tpa6130a2.
As far as I remember from the previous discussion that had been that making it a CODEC driver would be the simplest thing. Peter said in reply to my mail saying this:
| At least with my device I need to add some delay before enabling the amp, so | anyway I need to ahve the DAPM_HP in the machine driver.
but it'd seem that the amp driver could do this just as well, possibly based off platform data?