-----Original Message----- From: David Henningsson [mailto:david.henningsson@canonical.com] Sent: Wednesday, March 27, 2013 6:16 PM To: Lin, Mengdong Cc: alsa-devel@alsa-project.org; tiwai@suse.de Subject: Re: [alsa-devel] [PATCH] ALSA: hda - bug fix on return value when getting HDMI ELD info
On 03/27/2013 02:37 PM, mengdong.lin@intel.com wrote:
From: Mengdong Lin mengdong.lin@intel.com
In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0. Otherwise it will be returned uninitialized as non-zero after ELD info is got successfully. Thus hdmi_present_sense() will always assume ELD info is invalid by mistake, and /proc file system cannot show the proper ELD
info.
This patch also let debug message show 'pin_eld->monitor_present' which is the real pin response to verb GET_PIN_SENSE.
Signed-off-by: Mengdong Lin mengdong.lin@intel.com
Reviewed-by: David Henningsson david.henningsson@canonical.com
Good findings. The first one is at least in 3.8 and so this should be sent to stable too.
The second one (pin_eld) is new for 3.9, and probably caused by me, so, sorry for that :-/
Hi David,
I've divided them into two patches. Please review. [PATCH v2 1/2] ALSA: hda - bug fix on return value when getting HDMI ELD info [PATCH v2 2/2] ALSA: hda - bug fix on HDMI ELD debug message
Thanks again! Mengdong