17 Nov
2018
17 Nov
'18
4:18 a.m.
On Fri, Nov 16, 2018 at 05:28:56PM +0800, Cheng-Yi Chiang wrote:
The default implementation of regulator_set_load returns REGULATOR_MODE_NORMAL, which is positive.
The stub does indeed do that however that just looks like a bug - the actual implementation returns 0 on success and the other users don't seem to expect to get a mode value back.
rt5663_i2c_probe should only do error handling when return value of regulator_set_load is negative. In this case, rt5663_i2c_probe should return error.
However that's also true so the patch is valid.