On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy vsujithk@codeaurora.org
Signed-off-by: Srinivasa Rao srivasam@codeaurora.org Signed-off-by: V Sujith Kumar Reddy vsujithk@codeaurora.org
sound/soc/qcom/lpass-cpu.c | 2 +- sound/soc/qcom/lpass-platform.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 1ee6d8b..5d84f63 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -575,7 +575,7 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev)
of_lpass_cpu_parse_dai_data(dev, drvdata);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif");
Interesting!! this patch https://lore.kernel.org/alsa-devel/1597402388-14112-11-git-send-email-rohitk... just took it out and you add it back in!
Index is always preferred over name w.r.t device tree bindings, so lets stick with that for now! Unless you have any strong reason to lookup resource by name?
--srini
drvdata->lpaif = devm_ioremap_resource(dev, res); if (IS_ERR((void const __force *)drvdata->lpaif)) { diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c index df692ed..35aead1 100644 --- a/sound/soc/qcom/lpass-platform.c +++ b/sound/soc/qcom/lpass-platform.c @@ -638,7 +638,7 @@ int asoc_qcom_lpass_platform_register(struct platform_device *pdev) struct lpass_variant *v = drvdata->variant; int ret;
- drvdata->lpaif_irq = platform_get_irq(pdev, 0);
- drvdata->lpaif_irq = platform_get_irq_byname(pdev, "lpass-irq-lpaif"); if (drvdata->lpaif_irq < 0) return -ENODEV;