On 04/03/2013 07:08 PM, Stephen Warren wrote:
On 04/03/2013 03:06 AM, Lars-Peter Clausen wrote:
Use the common DAI DMA data struct for tegra, this allows us to use the common helper function to configure the DMA slave config based on the DAI DMA data.
Nice. Patches 2, 5, 6, Reviewed-by: Stephen Warren swarren@nvidia.com Tested-by: Stephen Warren swarren@nvidia.com
But one minor question below:
diff --git a/sound/soc/tegra/tegra_pcm.c b/sound/soc/tegra/tegra_pcm.c
@@ -92,16 +89,9 @@ static int tegra_pcm_hw_params(struct snd_pcm_substream *substream,
- snd_dmaengine_pcm_set_config_from_dai_data(substream,
snd_soc_dai_get_dma_data(rtd->cpu_dai, substream),&slave_config);Would it make sense to have snd_dmaengine_pcm_set_config_from_dai_data() call snd_soc_dai_get_dma_data() internally, to avoid all call-sites from having to do it?
Yes, I thought about that as well, but there are some platforms like mmp which we can't switch to using the generic DAI DMA data yet, but may find it useful to be able to use this function. So they'd initialize the dma data struct on the stack and pass it to the function.
- Lars