Hi Heiko,
Le 13/01/2017 à 17:43, Heiko Stuebner a écrit :
Hi Romain,
Am Freitag, 13. Januar 2017, 17:14:49 CET schrieb Romain Perier:
This commit adds a compatible string for everest,es8388. This is an audio codec that is compatible with es8328.
Signed-off-by: Romain Perier romain.perier@collabora.com
Documentation/devicetree/bindings/sound/es8328.txt | 2 +- sound/soc/codecs/es8328-i2c.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/es8328.txt b/Documentation/devicetree/bindings/sound/es8328.txt index 30ea8a3..33fbf05 100644 --- a/Documentation/devicetree/bindings/sound/es8328.txt +++ b/Documentation/devicetree/bindings/sound/es8328.txt @@ -4,7 +4,7 @@ This device supports both I2C and SPI.
Required properties:
- compatible : "everest,es8328"
- compatible : Should be "everest,es8328" or "everest,es8388"
- DVDD-supply : Regulator providing digital core supply voltage 1.8 -
3.6V - AVDD-supply : Regulator providing analog supply voltage 3.3V - PVDD-supply : Regulator providing digital IO supply voltage 1.8 - 3.6V diff --git a/sound/soc/codecs/es8328-i2c.c b/sound/soc/codecs/es8328-i2c.c index 2d05b5d..09ae67f 100644 --- a/sound/soc/codecs/es8328-i2c.c +++ b/sound/soc/codecs/es8328-i2c.c @@ -19,13 +19,14 @@ #include "es8328.h"
static const struct i2c_device_id es8328_id[] = {
- { "es8328", 0 },
- { "es8328", "es8388", 0 },
that looks strange or I'm just blind.
struct i2c_device_id { char name[I2C_NAME_SIZE]; kernel_ulong_t driver_data; /* Data private to the driver */ };
so shouldn't this be
static const struct i2c_device_id es8328_id[] = { { "es8328", 0 },
- { "es8388", 0 },
instead?
Good catch!
thanks, Romain