Hi Bo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next] [also build test WARNING on v4.20-rc1 next-20181105] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/He-Bo/fix-the-kernel-panic-due-to-w... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: i386-randconfig-x014-201844 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386
All warnings (new ones prefixed by >>):
sound/soc/intel/skylake/skl-pcm.c: In function 'skl_platform_register':
sound/soc/intel/skylake/skl-pcm.c:1489:28: warning: passing argument 2 of 'devm_kcalloc' makes integer from pointer without a cast [-Wint-conversion]
dais = devm_kcalloc(dev, skl->dais, sizeof(skl_fe_dai) + ^~~ In file included from include/linux/pci.h:31:0, from sound/soc/intel/skylake/skl-pcm.c:22: include/linux/device.h:690:21: note: expected 'size_t {aka unsigned int}' but argument is of type 'struct snd_soc_dai_driver *' static inline void *devm_kcalloc(struct device *dev, ^~~~~~~~~~~~
vim +/devm_kcalloc +1489 sound/soc/intel/skylake/skl-pcm.c
1468 1469 int skl_platform_register(struct device *dev) 1470 { 1471 int ret; 1472 struct snd_soc_dai_driver *dais; 1473 int num_dais = ARRAY_SIZE(skl_platform_dai); 1474 struct hdac_bus *bus = dev_get_drvdata(dev); 1475 struct skl *skl = bus_to_skl(bus); 1476 1477 INIT_LIST_HEAD(&skl->ppl_list); 1478 INIT_LIST_HEAD(&skl->bind_list); 1479 1480 skl->dais = kmemdup(skl_platform_dai, sizeof(skl_platform_dai), 1481 GFP_KERNEL); 1482 if (!skl->dais) { 1483 ret = -ENOMEM; 1484 goto err; 1485 } 1486 1487 if (!skl->use_tplg_pcm) { 1488 devm_kfree(dev, skl->dais);
1489 dais = devm_kcalloc(dev, skl->dais, sizeof(skl_fe_dai) +
1490 sizeof(skl_platform_dai), GFP_KERNEL); 1491 if (!dais) { 1492 ret = -ENOMEM; 1493 goto err; 1494 } 1495 1496 skl->dais = dais; 1497 memcpy(&skl->dais[ARRAY_SIZE(skl_platform_dai)], skl_fe_dai, 1498 sizeof(skl_fe_dai)); 1499 num_dais += ARRAY_SIZE(skl_fe_dai); 1500 } 1501 1502 ret = devm_snd_soc_register_component(dev, &skl_component, 1503 skl->dais, num_dais); 1504 if (ret) 1505 dev_err(dev, "soc component registration failed %d\n", ret); 1506 err: 1507 return ret; 1508 } 1509
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation