On Sun, 23 Nov 2014, Sudip Mukherjee wrote:
On Sun, Nov 23, 2014 at 01:48:06PM +0100, Julia Lawall wrote:
From: Julia Lawall Julia.Lawall@lip6.fr
Initialize err before returning on failure, as done elsewhere in the function.
<snip> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > sound/pci/ctxfi/ctatc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c > index 58b235c..a2f997a 100644 > --- a/sound/pci/ctxfi/ctatc.c > +++ b/sound/pci/ctxfi/ctatc.c > @@ -1725,8 +1725,10 @@ int __devinit ct_atc_create(struct snd_card *card, struct pci_dev *pci, > atc_connect_resources(atc); > > atc->timer = ct_timer_new(atc); > - if (!atc->timer) > + if (!atc->timer) { > + err = -ENOMEM; > goto error1; > + } > > err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, atc, &ops); > if (err < 0) > just a small doubt.. looks like this patch you have already sent on 19 Aug 2012 and has been already applied via 4d8ce1c9966663bad69e738952179f3cc52710bf
or am i missing something?
Yes, very sorry. I sent out the wrong patch series.
julia