On Mon, Oct 19, 2009 at 03:42:20PM +0300, Peter Ujfalusi wrote:
TWL4030 codec is now using the device registration via tlw4030_codec MFD device.
This looks pretty good but obviously depends on the MFD changes. The major thing that jumps out at me is the removal of the register definitions from the ASoC headers - it might be nice to have that done as part of the MFD patch, or as a separate patch.
You've also got the bias being brought up when the ASoC system comes up rather than when the driver comes up. To be honest it doesn't really make any difference either way, it's just slightly different to other drivers. What is useful with things like twl4030 which take a little while to come up is if you can do the bias bringup out of line from device probe, avoiding blocking system startup on CODEC bringup. That's definitely a separate patch, I'm just mentioning it for interest here.
There's also a couple of debug prints (like in the remove function) and
+MODULE_ALIAS("platform:twl4030_codec:audio");
Is that second colon right given...
- .driver = {
.name = "twl4030_codec_audio",.owner = THIS_MODULE,
this.