24 Aug
2020
24 Aug
'20
4:17 p.m.
I don't get this patch because there is no moving of a label, it just introduces it, where it is actually completely unused in the function as far as I can tell in both v5.9-rc1 and next-20200821. When building with clang in certain configurations, this introduces the same type of warning:
sound/soc/sof/intel/hda-codec.c:182:1: warning: unused label 'error' [-Wunused-label] error: ^~~~~~ 1 warning generated.
It seems like this should be reverted as it does not actually do anything.
I must have made a mistake with these cppcheck patches, the patch that needed to be fixed is not upstream but in the SOF tree. I will send it later today, sorry about the noise.