On 08/02/2023 19:46, Rob Herring wrote:
On Wed, 08 Feb 2023 18:25:52 +0100, Krzysztof Kozlowski wrote:
Convert the Wolfson WM1811/WM8994/WM8958 audio codecs bindings to DT schema.
Changes against original binding:
- Add missing LDO1VDD-supply for WM1811.
- Use "gpios" suffix for wlf,ldo1ena and wlf,ldo2ena (Linux kernel's gpiolib already looks for both variants).
- Do not require AVDD1-supply and DCVDD-supply, because at least on Arndale board with Exynos5250 these are grounded.
Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
.../devicetree/bindings/sound/wlf,wm8994.yaml | 203 ++++++++++++++++++ .../devicetree/bindings/sound/wm8994.txt | 112 ---------- 2 files changed, 203 insertions(+), 112 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8994.yaml delete mode 100644 Documentation/devicetree/bindings/sound/wm8994.txt
Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/2023020817255...
audio-codec@1a: 'AVDD1-supply' is a required property arch/arm/boot/dts/exynos5250-smdk5250.dtb arch/arm/boot/dts/s5pv210-fascinate4g.dtb arch/arm/boot/dts/s5pv210-galaxys.dtb
audio-codec@1a: 'DCVDD-supply' is a required property arch/arm/boot/dts/exynos5250-smdk5250.dtb arch/arm/boot/dts/s5pv210-fascinate4g.dtb arch/arm/boot/dts/s5pv210-galaxys.dtb
These two need corrections in the binding - next version of patch.
audio-codec@1a: Unevaluated properties are not allowed ('wlf,ldo1ena', 'wlf,ldo2ena' were unexpected) arch/arm/boot/dts/exynos4412-i9300.dtb
These are fixed here: https://lore.kernel.org/linux-samsung-soc/20230208172634.404452-1-krzysztof....
Best regards, Krzysztof