25 Jul
2013
25 Jul
'13
10:19 p.m.
On Thu, Jul 25, 2013 at 11:14:59AM +0200, Jean-Francois Moine wrote:
- if (np) {
priv->burst = 128; /* might be 32 or 128 */
- } else if (data) {
When you posted this before I queried how and why the value might vary - I see the code is the same and I don't recall a reply.
- priv->clk = devm_clk_get(&pdev->dev, NULL);
- priv->clk = devm_clk_get(&pdev->dev, "internal"); if (IS_ERR(priv->clk)) {
dev_err(&pdev->dev, "no clock\n");
return PTR_ERR(priv->clk); }dev_err(&pdev->dev, "no internal clock\n");
Does the code providing it already name the clock? If not are updates needed to do that?
- priv->extclk = clk_get(&pdev->dev, "extclk");
- priv->extclk = clk_get(&pdev->dev, "external");
Is the clock actually called extclk in the datasheet and so on? If so it seems better to stick with that name. Do any boards need updates for the new name?