On Fri, 24 Jul 2015 06:50:42 +0200, woodrow.shen@canonical.com wrote:
From: Woodrow Shen woodrow.shen@canonical.com
Fix the headset mic that will not work on Dell desktop machine. BugLink: https://bugs.launchpad.net/bugs/1475553 Signed-off-by: Woodrow Shen woodrow.shen@canonical.com
I have repeatedly received patches with the very same subject and with the very similar content but without further explanation. It's too confusing.
Please look through the git commit history of this file, and re-read your patch. Then, consider a more useful subject / description, and resubmit the patch.
thanks,
Takashi
sound/pci/hda/patch_realtek.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 742fc62..d94c0e3 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5473,6 +5473,28 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x1e, 0x411111f0}, {0x21, 0x0221103f}), SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
{0x12, 0x40000000},{0x14, 0x90170150},{0x17, 0x411111f0},{0x18, 0x411111f0},{0x19, 0x411111f0},{0x1a, 0x411111f0},{0x1b, 0x02011020},{0x1d, 0x4054c029},{0x1e, 0x411111f0},{0x21, 0x0221105f}),- SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
{0x12, 0x40000000},{0x14, 0x90170110},{0x17, 0x411111f0},{0x18, 0x411111f0},{0x19, 0x411111f0},{0x1a, 0x411111f0},{0x1b, 0x01014020},{0x1d, 0x4054c029},{0x1e, 0x411111f0},{0x21, 0x0221101f}),- SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, {0x12, 0x90a60160}, {0x14, 0x90170120}, {0x17, 0x90170140},
-- 2.1.4