On Wed, 27 Oct 2021 14:56:35 +0100, Patrice CHOTARD patrice.chotard@foss.st.com wrote:
Hi Marc
+Joe Perches
On 10/27/21 8:11 AM, Patrice CHOTARD wrote:
Hi Marc
On 10/20/21 1:39 PM, Marc Zyngier wrote:
On Wed, 20 Oct 2021 08:45:02 +0100, Krzysztof Kozlowski krzysztof.kozlowski@canonical.com wrote:
On 20/10/2021 08:50, patrice.chotard@foss.st.com wrote:
From: Patrice Chotard patrice.chotard@foss.st.com
Not all @st.com email address are concerned, only people who have a specific @foss.st.com email will see their entry updated. For some people, who left the company, remove their email.
Please split simple address change from maintainer updates (removal, addition).
Also would be nice to see here explained *why* are you doing this.
And why this can't be done with a single update to .mailmap, like anyone else does.
Thanks for the tips, yes, it will be simpler.
Thanks Patrice
M.
I made a try by updating .mailmap with adding a new entry with my @foss.st.com email :
Pali Rohár pali@kernel.org pali.rohar@gmail.com Paolo 'Blaisorblade' Giarrusso blaisorblade@yahoo.it +Patrice Chotard patrice.chotard@foss.st.com patrice.chotard@st.com Patrick Mochel mochel@digitalimplant.org Paul Burton paulburton@kernel.org paul.burton@imgtec.com
But when running ./scripts/get_maintainer.pl Documentation/devicetree/bindings/arm/sti.yaml, by old email is still displayed
Rob Herring robh+dt@kernel.org (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Patrice Chotard patrice.chotard@st.com (in file) devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-kernel@vger.kernel.org (open list)
By default, the get_maintainer.pl script is using .mailmap file ($email_use_mailmap = 1).
It seems there is an issue with get_maintainer.pl and maintainer name/e-mail found in yaml file ?
Try this (warning though: my Perl-foo is non-existent).
M.
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 2075db0c08b8..2a84a3fb0130 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -986,6 +986,7 @@ sub get_maintainers { my ($name, $address) = parse_email($email);
my $tmp_email = format_email($name, $address, $email_usename); + $tmp_email = mailmap_email($tmp_email); push_email_address($tmp_email, ''); add_role($tmp_email, 'in file'); }