8 Dec
2014
8 Dec
'14
4:53 p.m.
On Mon, Dec 08, 2014 at 04:43:17PM +0100, Takashi Iwai wrote:
Mark Brown wrote:
For fixing a build error with CONFIG_SND_JACK=n sound/soc/codecs/ts3a227e.c:223:2: error: implicit declaration of function ‘snd_jack_set_key’ [-Werror=implicit-function-declaration]
The device probably should be ensuring that the jack detection is enabled - the device doesn't do anything except jack detection.
Yes. But apart from that, still it's better to have the corresponding dummy function,
That's not always the case - there's some interfaces that should really only be used by something that really has a strong dependency on the feature, things will go wrong if the driver thinks the feature is doing something and it isn't. This one should be fine though.