On 2022-05-29 3:50 PM, Uwe Kleine-König wrote:
A more short-term fix would be:
diff --git a/sound/soc/intel/avs/board_selection.c b/sound/soc/intel/avs/board_selection.c --- a/sound/soc/intel/avs/board_selection.c +++ b/sound/soc/intel/avs/board_selection.c @@ -325,8 +325,8 @@ static int avs_register_i2s_board(struct avs_dev *adev, struct snd_soc_acpi_mach num_ssps = adev->hw_cfg.i2s_caps.ctrl_count; if (fls(mach->mach_params.i2s_link_mask) > num_ssps) { dev_err(adev->dev, "Platform supports %d SSPs but board %s requires SSP%ld\n",
num_ssps, mach->drv_name, __fls(mach->mach_params.i2s_link_mask));
num_ssps, mach->drv_name, (unsigned long)__fls(mach->mach_params.i2s_link_mask)); return -ENODEV;i.e. explicitly cast the return value of __fls to unsigned long.
This looks very good indeed. Will you be updating the patch you had sent earlier today or would you like me to send it instead?
If you choose the former, feel free to append:
Reviewed-by: Cezary Rojewski cezary.rojewski@intel.com
Regards, Czarek