On Wed, Dec 18, 2019 at 5:37 PM Arnd Bergmann arnd@arndb.de wrote:
In a rare randconfig build I came across one configuration that does not enable CONFIG_GPIOLIB, which is needed by lochnagar:
ERROR: "devm_gpiochip_add_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! ERROR: "gpiochip_generic_free" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! ERROR: "gpiochip_generic_request" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! ERROR: "gpiochip_get_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined!
Add another 'select' like all other pinctrl drivers have.
Fixes: 0548448b719a ("pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagar") Signed-off-by: Arnd Bergmann arnd@arndb.de
Patch applied!
I wonder if GPIOLIB should just become mandatory when enabling the pinctrl subsystem, or if there are still good reasons for leaving it disabled on any machine that uses CONFIG_PINCTRL.
Hm that is a tricky question, they almost always come in pair but are technically speaking separate subsystems.
I have a (very) long-term plan to merge them at some point before I retire :D
Yours, Linus Walleij