17 Oct
2014
17 Oct
'14
11:44 a.m.
On Thu, Oct 16, 2014 at 08:00:14PM +0530, Vinod Koul wrote:
+static void memcpy32_toio(void __iomem *dst, const void *src, int count) +{
- int i;
- const u32 *src_32 = src;
- u32 *dst_32 = dst;
- for (i = 0; i < count/sizeof(u32); i++)
writel(*src_32++, dst_32++);+}
We also have a memcpy32_toio in atmel_nand.c which I pointed out before and now another in mxc_nand.c. All of which use different writel variants. This isn't awesome, we should at least try to clean this up rather than add another duplicate - by the time we're onto the third user there's a clear need for something generic. Do you have any thoughts on dealing with this?
Otherwise the patch looks good.