Re: [alsa-devel] [PATCH 2/3] mfd: mc13xxx: Move SPI erratum workaround into SPI I/O function

Please delete irrelevant context from mails, it makes it easier to find the new content that's beenn added.

I did, off the bottom.

I only left 22 lines at the top. You're just being pernickety.

...

On Wed, 18 Sep 2013, Mark Brown wrote:

...

...

@@ -94,10 +94,15 @@ static int mc13xxx_spi_write(void *context, const void *data, size_t count) { struct device *dev = context; struct spi_device *spi = to_spi_device(dev);

• char *reg = data;

...

I think this requires a cast.

No, you should never need a cast to or from void in C - it probably does want to be a const char though.

Either way, it needs changing.