Re: [PATCH v1 2/5] ASoC: dt-bindings: snps,designware-i2s: Add StarFive JH7110 SoC support

7 Aug 2023

      On 2023/8/7 17:17, Krzysztof Kozlowski wrote:
...
On 07/08/2023 11:03, Xingyu Wu wrote:
...
...
...
...

if:

 properties:

   compatible:

     contains:

       const: snps,designware-i2s

then:
 properties:

   clocks:

     maxItems: 1

   clock-names:

     maxItems: 1

   resets:

     maxItems: 1

else:
 properties:

   resets:

     minItems: 2

The resets of TX0/TX1/RX on JH7110 SoC are mentioned in 'else' here.
Ah, its fine. Clocks seem to be also constrained.
OK, I will keep it here.
...
...
...
...

if:

 properties:

   compatible:

     contains:

       const: starfive,jh7110-i2stx0

then:
 properties:

   clocks:

     minItems: 5

Also maxItems
Will add.
...
...

   clock-names:

     minItems: 5

Also maxItems
Will add.
...
What about resets? 1 or 2 items?
Mentioned it in the 'else'.
Or do you mean I should drop the 'else' and add the resets in here?
And is the same for TX1 and RX?
It won't be easy to read... probably the binding should be split.
Anyway, it's fine as is, except the maxItems above.
So I will keep it and just add the maxItems in next version.
Thanks,
Xingyu Wu