Dne Saturday 05 of July 2008 00:19:08 Marek Vasut napsal(a):
Dne Friday 04 of July 2008 22:26:15 Mark Brown napsal(a):
On Fri, Jul 04, 2008 at 09:49:57PM +0200, Marek Vasut wrote:
Like Liam said, audio patches should be CCed to alsa-devel as well - a
couple of comments from a quick scan through:
- /* add palmtx specific widgets */
- for (i = 0; i < ARRAY_SIZE(palmtx_dapm_widgets); i++)
snd_soc_dapm_new_control(codec, &palmtx_dapm_widgets[i]);Ideally this should use the new snd_soc_dapm_new_controls() function...
- /* set up palmtx specific audio path audio_map */
- for (i = 0; audio_map[i][0] != NULL; i++)
snd_soc_dapm_connect_input(codec, audio_map[i][0],audio_map[i][1], audio_map[i][2]);and this should use snd_soc_dapm_add_routes (which would also mean you could drop the null terminator from audio_map()). Both are queued for merge in the window - see ALSA git, it'll also appear in linux-next.
- ret = platform_device_add(palmtx_snd_device);
- if (!ret)
return 0;- platform_device_put(palmtx_snd_device);
It took me a double take to follow this - it'd be more idiomatic to say:
if (ret != 0) goto put_device;
return 0; put_device:
ok, I applied some alsa patches to my branch of "devel"
even better version of the previous one