On 30. 09. 24 15:41, Maciej Strozek wrote:
Both 'Speaker Digital' and 'cs42l43 PDM2' names were found as substrings in other alsa controls, confusing the MixerElems paths. Make them unique to avoid errors for hardware mutes. Also add 'Capture' string into microphone controls to make them work properly.
Fixes: e87dde51d689 ("sof-soundwire: Add basic support for cs42l43") Fixes: e4277a204cd6 ("sof-soundwire: Add support for cs42l43/cs35l56 bridge configuration") Signed-off-by: Maciej Strozek mstrozek@opensource.cirrus.com
ucm2/codecs/cs42l43/init.conf | 4 ++-- ucm2/sof-soundwire/cs35l56-bridge.conf | 6 +++--- ucm2/sof-soundwire/cs42l43-dmic.conf | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/ucm2/codecs/cs42l43/init.conf b/ucm2/codecs/cs42l43/init.conf index 10a6e1f..cf61833 100644 --- a/ucm2/codecs/cs42l43/init.conf +++ b/ucm2/codecs/cs42l43/init.conf @@ -2,11 +2,11 @@
LibraryConfig.remap.Config { ctl.default.map {
"name='cs42l43 PDM2 Switch'" {
"name='cs42l43 Microphone Capture Switch'" {
This looks like a good cleanup.
LibraryConfig.remap.Config { ctl.default.map {
"name='Speaker Digital Switch'" {
"name='Speaker Combined Switch'" {
Combined? This string is for users not for developers. Please, find a better name describing the purpose of the control from the the user view. The old name is fine IMHO.
Jaroslav