On Thu, 21 Nov 2019 15:37:46 +0100, Thorsten Glaser wrote:
On Thu, 21 Nov 2019, Takashi Iwai wrote:
Could you split these changes to separate patches? They are for different purposes.
I’ve sent them as two separate patch files attachments.
Then please make them cleanly applicable via git-am, with a proper subject, a proper changelog and your sign-off, etc. At best send one patch per mail (and with a cover letter for multiple patches).
Also, using time_t would be better if possible. Unfortunately a cast is needed for printf usage, but other than that, time_t would leave us the right size.
In timediff() you mean? Hrm, indeed. I tried to be minimal-invasive at first.
I meant using time_t as much as possible instead of long long. For printf(), there is no other option, but other calculations can be replaced with time_t.
thanks,
Takashi