On Fri, 09 Jun 2017 05:40:04 +0200, Vinod Koul wrote:
On Wed, Jun 07, 2017 at 11:40:19PM +0200, Takashi Iwai wrote:
On Tue, 23 May 2017 02:12:58 +0200, Matthias Kaehlcke wrote:
Looks like the function has never been used since it was added by commit b0d94acd634a ("ASoC: Intel: mrfld - add shim save restore"). Removing it fixes the following warning when building with clang:
sound/soc/intel/atom/sst/sst.c:360:20: error: unused function 'sst_restore_shim64' [-Werror,-Wunused-function]
Signed-off-by: Matthias Kaehlcke mka@chromium.org
Hmm, although this patch was already merged, I now think this is rather a bug. If the restore is never executed, why the counterpart, sst_save_shim64() is required at all at runtime suspend?
Vinod?
It was supposed to be required in early BYT boards. I do not seem to recall why the call to sst_restore_shim64 was removed from resume routine, it was there when we added it and due to file move git log is useless.
Any idea how to get changes to file before the file was moved?
Try to pass --follow option to git log.
sst_save_shim64() and sst_restore_shim64() were introduced at b0d94acd634a5cff7fe5fc46131a23997e8d0f60 but not actually used.
The call of sst_save_shim64() was added in 336cfbb05edf7b122ea927dad6c746608723eb25 but already without the counter-part for restore.
thanks,
Takashi