Re: [alsa-devel] [PATCH 1/2] ASoC: tlv320aic32x4: always enable dividers

On Wed, Jan 18, 2012 at 10:50:54AM +0000, Mark Brown wrote:

On Wed, Jan 18, 2012 at 11:48:58AM +0100, Wolfram Sang wrote:

...

• /* Switch on PLL */
  

• snd_soc_update_bits(codec, AIC32X4_PLLPR,
  

• 		    AIC32X4_PLLEN, AIC32X4_PLLEN);
  

Looking at this code it looks a lot like these ought to be supplies, not that that needs to be fixed right now.

A lot of things need to be fixed in that driver I think. I am still figuring what incremental set of steps would make sense. Sadly, I am not an ASoC expert and I won't have endless time for this task, but at least there is another driver [1] as a working reference. I'll see what I can come up with in that time, probably reg-caching is next.

Regards,

Wolfram

[1] http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-06/msg07236.html