Re: [alsa-devel] [PATCH 9/9] ASoC: wm8996: Fix negative array index read

30 Oct 2013

      At Wed, 30 Oct 2013 09:51:03 -0700,
Mark Brown wrote:
...
On Wed, Oct 30, 2013 at 08:35:07AM +0100, Takashi Iwai wrote:
...
int block = wm8996_get_retune_mobile_block(kcontrol->id.name);

if (block < 0)
return block;

ucontrol->value.enumerated.item[0] = wm8996->retune_mobile_cfg[block];

Applied, but this only fixes some of the problem - there's nothing
validating that block is in bounds for the array, this now adds code
which validates the lower but not upper bound for this.
The function returns either -EINVAL, 0 or 1, so no need for upper
bound check.
Takashi